-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIKE][DSS-29] ongoing feedback display #1686
Draft
teenwolfblitzer
wants to merge
23
commits into
develop
Choose a base branch
from
DSS-29_ongoing-feedback-display
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teenwolfblitzer
force-pushed
the
DSS-29_ongoing-feedback-display
branch
3 times, most recently
from
February 28, 2023 20:28
7b2770e
to
1868065
Compare
teenwolfblitzer
force-pushed
the
DSS-29_ongoing-feedback-display
branch
from
March 1, 2023 23:19
1868065
to
e88e34e
Compare
teenwolfblitzer
force-pushed
the
DSS-29_ongoing-feedback-display
branch
2 times, most recently
from
April 11, 2023 16:38
49d1389
to
79b5e21
Compare
ju-Skinner
force-pushed
the
develop
branch
7 times, most recently
from
November 7, 2023 21:14
694e1d8
to
50aee97
Compare
ju-Skinner
force-pushed
the
develop
branch
2 times, most recently
from
November 13, 2023 15:52
11dde9c
to
48f6933
Compare
ju-Skinner
force-pushed
the
develop
branch
6 times, most recently
from
March 13, 2024 15:50
81a9318
to
da9b7c3
Compare
ju-Skinner
force-pushed
the
develop
branch
10 times, most recently
from
March 26, 2024 14:35
7caaef2
to
3359401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation changes to improve feedback collection and wayfinding. See discovery doc for additional details.
These changes are intended as a stopgap while focus moves to Pine. Full implementation of the revised documentation site design is a much larger lift.
Support
Per-page ratings in footer nav popupdropped due to licensing issuesSearch
This branch also extends Rails Search queries to include component descriptions. Adds some related results, but scope is still limited compared to Storybook
Wayfinding and navigation
deprecated
incomponent_helper.rb
Screenshots
Support view
before:after:
Search results
before:after:
Active nav and sidebar icons
before:after:
Mobile nav backdrop overlap
before:after:
Testing in
sage-lib
Testing in
kajabi-products
Related